Skip to content

fix panic when the runtime config is null #7062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix panic when the runtime config is null #7062

merged 1 commit into from
Oct 23, 2025

Conversation

@SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Oct 22, 2025 •
edited
Loading

This PR fixes a panic that occurs when clearing all runtime configurations via a Helm chart. The panic was caused by the runtime config being null. This PR adds a check to handle the null case and prevent the crash.

How to reproduce

Clear all runtime_config in the helm chart like:

runtimeconfigmap:
  create: true
  annotations: {}
  runtime_config:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the type/bug label Oct 22, 2025
@SungJin1212 SungJin1212 force-pushed the fix-panic-when-runtime-config-null branch from 8152822 to 00a055e Compare October 22, 2025 02:21
@yeya24 yeya24 merged commit 1b3d767 into cortexproject:master Oct 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees

No one assigned

Labels

size/S type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SungJin1212 @yeya24